lkml.org 
[lkml]   [2006]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2/8] Implement always-locked bit ops, for memory shared with an SMP hypervisor.
    On Thu, 3 Aug 2006, Andi Kleen wrote:

    > On Thursday 03 August 2006 07:54, Christoph Lameter wrote:
    > > On Thu, 3 Aug 2006, Andi Kleen wrote:
    > >
    > > > > I still wonder why you are so focused on ifdefs. Why would we need those?
    > > >
    > > > Because the Xen drivers will run on a couple of architectures, including
    > > > IA64 and PPC.
    > > >
    > > > If IA64 or PPC didn't implement at least wrappers for the sync ops
    > > > then they would all need special ifdefs to handle this.
    > >
    > > No they would just need to do an #include <xen-bitops.h>
    >
    > If IA64 and PPC64 wouldn't have xen-bitops.h (which you seem to argue
    > for) then they would need ifdefs.

    An include <asm/xen-bitops.h> would need to fall back to asm-generic if
    there is no file in asm-arch/xen-bitops.h. I thought we had such a
    mechanism?

    > You mean into asm-generic/bitops.h? Then it would need ifdefs
    > to handle the i386/x86-64 case.

    No. Into asm-generic/xen-bitops.h.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-03 18:53    [W:0.020 / U:30.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site