lkml.org 
[lkml]   [2006]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RPC] OLPC tablet input driver.
    From
    Date
    > +#undef DEBUG
    > +#ifdef DEBUG
    > +#define dbg(format, arg...) printk(KERN_INFO "olpc.c(%d): " format "\n", __LINE__, ## arg)
    > +#else
    > +#define dbg(format, arg...) do {} while (0)
    > +#endif

    why not use pr_debug or even dev_debug() ?
    Those already have this ifdef included

    > +
    > +static struct olpc_model_info olpc_model_data[] = {
    > + { { 0x67, 0x00, 0x0a }, 0xeb, 0xff, OLPC_PTGS }, /* OLPC in PT+GS mode. */
    > +};

    const?



    also.. there's no locking visible anywhere in the driver... is this
    right?

    Greetings,
    Arjan van de Ven

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-29 10:13    [W:0.021 / U:60.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site