lkml.org 
[lkml]   [2006]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] acpi hotplug cleanups, move install notifier to add function
> @@ -390,6 +296,13 @@ static int acpi_memory_device_add(struct
> if (!device)
> return -EINVAL;
>
> + /* Check for _STA and EJ0 func */
> + if (!device->flags.dynamic_status || !device->flags.ejectable){
> + printk(KERN_INFO PREFIX "Memory device %s has no _STA or"
> + "EJ0/EJD function", acpi_device_bid(device));
> + return -ENODEV;
> + }
> +
> mem_device = kmalloc(sizeof(struct acpi_memory_device), GFP_KERNEL);
> if (!mem_device)
> return -ENOMEM;

One comment.

Memory device might not have _EJ0/_EJD, but parent device
(like one NUMA node) might be able to be ejectable.
In this case, only the parent device has _EJ0/_EJD.
So, one more check is necessary.

(If a node is hot-added, container driver of acpi calls acpi_memhotplug
driver.)


Thanks.

--
Yasunori Goto


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-28 10:13    [W:0.116 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site