Messages in this thread Patch in this message | | | Date | Mon, 28 Aug 2006 22:04:16 +0200 | From | Andreas Mohr <> | Subject | [PATCH -mm] lib/rwsem.c: un-inline rwsem_down_failed_common() |
| |
Un-inlining rwsem_down_failed_common() (two callsites) reduced lib/rwsem.o on my Athlon, gcc 4.1.2 from 5935 to 5480 Bytes (455 Bytes saved).
I thus guess that reduced icache footprint (and better function caching) is worth more than any function call overhead.
Compile-tested and run-tested on 2.6.18-rc4-mm3.
Signed-off-by: Andreas Mohr <andi@lisas.de>
--- linux-2.6.18-rc4-mm3.orig/lib/rwsem.c 2006-08-22 21:09:55.000000000 +0200 +++ linux-2.6.18-rc4-mm3/lib/rwsem.c 2006-09-05 21:52:09.000000000 +0200 @@ -146,7 +146,7 @@ /* * wait for a lock to be granted */ -static inline struct rw_semaphore * +static struct rw_semaphore * rwsem_down_failed_common(struct rw_semaphore *sem, struct rwsem_waiter *waiter, signed long adjustment) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |