lkml.org 
[lkml]   [2006]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: LogFS
Date
On Aug 27, 2006, at 13:17:28, Jörn Engel wrote:
> On Sun, 27 August 2006 01:32:45 -0400, Ian Lindsay wrote:
>> +/* FIXME: This should really be somewhere in the 64bit area. */
>> +#define LOGFS_LINK_MAX (2^30)
>>
>> Interesting choice of constant.
>
> Yes. I didn't spend a long time thinking about whether it should
> be 2^31 or 2^31-1 or 2^31-2. It will be a while before it becomes
> an issue in real life anyway. :)

Uhm, I think his point is that "^" is the xor operation:
2^30 == 28
2^31 == 29
2^21-1 == 28
2^21-2 == 31

Probably what you wanted was something more like this:

# define LOGFS_LINK_MAX (1<<30)

Cheers,
Kyle Moffett

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-27 20:07    [W:0.046 / U:2.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site