![]() | |||||||||||||
Messages in this thread |
On Fri, 2006-07-14 at 01:25 +0100, David Woodhouse wrote: > On Tue, 2006-07-11 at 17:35 -0700, Jim Gifford wrote: > > I will only document one issue, but there are several more like this > > in the kernel. > > Please elaborate, preferably in 'diff -u' form as below... Got any more, Jim? > > I'm going to use the MIPS architecture in my example, along with the > > file page.h. Ralf, you haven't applied this yet AFAICT... > [PATCH] Reduce user-visible noise in asm-mips/page.h > > Since PAGE_SIZE is variable according to configuration options, don't > expose it to userspace. Userspace should be using sysconf(_SC_PAGE_SIZE) > instead. Move some other noise inside __KERNEL__ too while we're at it. > > Signed-off-by: David Woodhouse <dwmw2@infradead.org> > > diff --git a/include/asm-mips/page.h b/include/asm-mips/page.h > index 6ed1151..ee2ef88 100644 > --- a/include/asm-mips/page.h > +++ b/include/asm-mips/page.h > @@ -14,8 +14,6 @@ #ifdef __KERNEL__ > > #include <spaces.h> > > -#endif > - > /* > * PAGE_SHIFT determines the page size > */ > @@ -35,7 +33,6 @@ #define PAGE_SIZE (1UL << PAGE_SHIFT) > #define PAGE_MASK (~((1 << PAGE_SHIFT) - 1)) > > > -#ifdef __KERNEL__ > #ifndef __ASSEMBLY__ > > extern void clear_page(void * page); > @@ -168,7 +165,6 @@ #define VM_DATA_DEFAULT_FLAGS (VM_READ | > #define UNCAC_ADDR(addr) ((addr) - PAGE_OFFSET + UNCAC_BASE) > #define CAC_ADDR(addr) ((addr) - UNCAC_BASE + PAGE_OFFSET) > > -#endif /* defined (__KERNEL__) */ > > #ifdef CONFIG_LIMITED_DMA > #define WANT_PAGE_VIRTUAL > @@ -177,4 +173,6 @@ #endif > #include <asm-generic/memory_model.h> > #include <asm-generic/page.h> > > +#endif /* defined (__KERNEL__) */ > + > #endif /* _ASM_PAGE_H */ > > -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2006-08-26 18:13 [from the cache] ©2003-2008 | |||||||||||||