Messages in this thread | | | Date | Fri, 25 Aug 2006 16:01:15 -0700 | From | "Randy.Dunlap" <> | Subject | Re: another NUMA build error |
| |
On Fri, 25 Aug 2006 15:44:58 -0700 Keith Mannthey wrote:
> On 8/25/06, Randy.Dunlap <rdunlap@xenotime.net> wrote: > > On Fri, 25 Aug 2006 14:43:50 +0900 KAMEZAWA Hiroyuki wrote: > > > > > On Thu, 24 Aug 2006 21:35:59 -0700 > > > "Randy.Dunlap" <rdunlap@xenotime.net> wrote: > > > > > > > Hi, > > > > I was just trying to reproduce that 'register_one_node' > > > > build error (and couldn't even with the supplied .config file; > > > > weird). Anyway, after I enabled CONFIG_NUMA (but not CONFIG_ACPI), > > > > I got the following error message. Seems that some config > > > > options should prevent this config from even being possible > > > > to create. Any ideas or suggestions? > > > > > > > Hi, there are 2 ways. > > > > > > 1. allow only 2 configs for i386/NUMA > > > - CONFIG_NUMA + CONFIG_ACPI + CONFIG_ACPI_SRAT > > > - CONFIG_NUMA + CONFIG_X86_NUMAQ > > > 2. allow this and fix include/asm-i386/mmzone.h > > > - CONFIG_NUMA + !CONFIG_ACP > > > > > > Which is sane ? > > > > I really can't answer that one. The people who care about > > NUMA would have to do that. It just shouldn't be possible > > to make a config with a build error like this. > > I thought there was a patch fix a while ago to fix this build issue. > If you want to anything that includes the SUMMIT sub arch you need > CONFIG_ACPI_SRAT. > > Option 1 is a good solution as only NUMAQ and ACPI_SRAT have tables > that are used to setup NUMA in the kernel. > > > OK, I prefer option 2 because it is more generic (not hardware- > > specific). Someone else can prefer option 1 because it is > > hardware-specific. :) > > I guess I am that other person. Really you only want/need NUMA if you > have ACPI_SRAT (Summit) or NUMAQ.
That's fine. Any fix is OK with me, as long as a .config won't generate a build error.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |