lkml.org 
[lkml]   [2006]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]
On Fri, Aug 25, 2006 at 08:37:07PM +0100, David Howells wrote:
> From: David Howells <dhowells@redhat.com>
>
> Move the bounce buffer code from mm/highmem.c to mm/bounce.c so that it can be
> more easily disabled when the block layer is disabled.
>
> !!!NOTE!!! There may be a bug in this code: Should init_emergency_pool() be
> contingent on CONFIG_HIGHMEM?
>
> Signed-Off-By: David Howells <dhowells@redhat.com>
> ---
>
> mm/Makefile | 4 +
> mm/bounce.c | 302 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> mm/highmem.c | 281 ------------------------------------------------------
> 3 files changed, 305 insertions(+), 282 deletions(-)
>
> diff --git a/mm/Makefile b/mm/Makefile
> index 9dd824c..63637f0 100644
> --- a/mm/Makefile
> +++ b/mm/Makefile
> @@ -12,6 +12,9 @@ obj-y := bootmem.o filemap.o mempool.o
> readahead.o swap.o truncate.o vmscan.o \
> prio_tree.o util.o mmzone.o vmstat.o $(mmu-y)
>
> +ifeq ($(CONFIG_MMU),y)
> +obj-y += bounce.o
> +endif

CONFIG_MMU is a bool so you can do this much more elegant:
obj-$(CONFIG_MMU) += bounce.o


Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-25 22:03    [from the cache]
©2003-2011 Jasper Spaans