lkml.org 
[lkml]   [2006]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH -mm] x86_64: Adjust the timing of initializing cyc2ns_scale.
    From
    The x86_64-mm-monotonic-clock.patch in 2.6.18-rc4-mm2 made a change to
    the updating of monotonic_base. It now uses cycles_2_ns().

    I suggest that a set_cyc2ns_scale() should be done prior to the setup_irq().
    Because cycles_2_ns() can be called from the timer ISR right after the irq0
    is enabled.


    Signed-off-by: Toyo Abe <toyoa@mvista.com>

    ---

    arch/x86_64/kernel/time.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/x86_64/kernel/time.c b/arch/x86_64/kernel/time.c
    index 5bbd05d..03ddc1a 100644
    --- a/arch/x86_64/kernel/time.c
    +++ b/arch/x86_64/kernel/time.c
    @@ -928,10 +928,10 @@ #endif
    vxtime.quot = (USEC_PER_SEC << US_SCALE) / vxtime_hz;
    vxtime.tsc_quot = (USEC_PER_MSEC << US_SCALE) / cpu_khz;
    vxtime.last_tsc = get_cycles_sync();
    - setup_irq(0, &irq0);
    -
    set_cyc2ns_scale(cpu_khz);

    + setup_irq(0, &irq0);
    +
    hotcpu_notifier(time_cpu_notifier, 0);
    time_cpu_notifier(NULL, CPU_ONLINE, (void *)(long)smp_processor_id());

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-08-25 18:47    [W:0.019 / U:0.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site