[lkml]   [2006]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC][PATCH] unify all architecture PAGE_SIZE definitions
    On Fri, 2006-08-25 at 08:42 -0700, Christoph Lameter wrote:
    > I think this is a good thing to do. However, the patch as it is now is
    > difficult to review. Could you split the patch into multiple patches? One
    > patch that introduces the generic functionality and then do one patch
    > per arch? It would be best to sent the arch specific patches to the arch
    > mailing list or the arch maintainer for review.
    > You probably can get the generic piece into mm together with the first
    > arch specific patch (once the first arch has signed off) and then submit
    > further bits as the reviews get completed.

    It _is_ too big. However, I think doing 24 different architectures
    separately would probably be a major pain, and never get done. It would
    also have to create some temporary Kconfig names (or give up the names
    it uses now, which duplicate some arch code).

    How about this: I'll split it up, one patch for each of the difficult
    architectures: parisc, mips, sparc64, ia64, one patch for the 4k-only
    page architectures, and we'll look at what's left?

    -- Dave

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-08-25 17:55    [W:0.020 / U:16.352 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site