lkml.org 
[lkml]   [2006]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] kthread: update s390 cmm driver to use kthread
    On Thu, Aug 24, 2006 at 04:22:42PM -0500, Serge E. Hallyn wrote:
    > Update the s390 cooperative memory manager, which can be a module,
    > to use kthread rather than kernel_thread, whose EXPORT is deprecated.
    >
    > This patch compiles and boots fine, but I don't know how to really
    > test the driver.

    NACK. Please do a real conversion to the kthread paradigm instead of
    doctoring around the trivial bits that could be changed with a script.

    Please use kthread_should_stop() and remove the cmm_thread_wait
    waitqueue in favour of wake_up_process. The timer useage could
    probably be replaced with smart usage of schedule_timeout().
    Also the code seems to miss a proper thread termination on module
    removal.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-25 16:43    [W:0.021 / U:33.580 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site