Messages in this thread |  | | | Date | Fri, 25 Aug 2006 15:30:09 +0400 | | From | Kirill Korotaev <> | | Subject | Re: [Devel] [PATCH 1/6] BC: kconfig |
| |
Matt Helsley wrote: > On Wed, 2006-08-23 at 15:04 -0700, Dave Hansen wrote: > >>On Wed, 2006-08-23 at 15:01 +0400, Kirill Korotaev wrote: >> >>>--- ./arch/sparc64/Kconfig.arkcfg 2006-07-17 17:01:11.000000000 +0400 >>>+++ ./arch/sparc64/Kconfig 2006-08-10 17:56:36.000000000 +0400 >>>@@ -432,3 +432,5 @@ source "security/Kconfig" >>> source "crypto/Kconfig" >>> >>> source "lib/Kconfig" >>>+ >>>+source "kernel/bc/Kconfig" >> >>... >> >>>--- ./arch/sparc64/Kconfig.arkcfg 2006-07-17 17:01:11.000000000 +0400 >>>+++ ./arch/sparc64/Kconfig 2006-08-10 17:56:36.000000000 +0400 >>>@@ -432,3 +432,5 @@ source "security/Kconfig" >>> source "crypto/Kconfig" >>> >>> source "lib/Kconfig" >>>+ >>>+source "kernel/bc/Kconfig" >> >>Is it just me, or do these patches look a little funky? Looks like it >>is trying to patch the same thing into the same file, twice. Also, the >>patches look to be -p0 instead of -p1. > > > They do appear to be -p0 it is -p1. patches are generated with gendiff and ./ in names is for -p1
> They aren't adding the same thing twice to the same file. This patch > makes different arches source the same Kconfig. > > I seem to recall Chandra suggested that instead of doing it this way it > would be more appropriate to add the source line to init/Kconfig because > it's more central and arch-independent. I tend to agree. agreed. init/Kconfig looks like a good place for including kernel/bc/Kconfig
Kirill
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |