Messages in this thread | | | From | Neil Brown <> | Date | Thu, 24 Aug 2006 16:12:52 +1000 | Subject | Re: [PATCH] nfsd: lockdep annotation |
| |
On Wednesday August 23, a.p.zijlstra@chello.nl wrote: > Hi, > > while doing a kernel make modules_install install over an NFS mount. > ( > > ============================================= > [ INFO: possible recursive locking detected ] > ---------------------------------------------
Thanks for the patch. I had a patch to fix this in my queue, but I just hadn't got around to submitting it yet :-( Never mind, we'll go with yours and Andrew already has it.
I had flags the fh_lock in nfsd_setattr a I_MUTEX_CHILD which you didn't however I see that isn't needed (Why do we have PARENT and CHILD and NORMAL.... you would think that any two would do ??)
However there is a bit missing: the fh_lock in nfsd_proc_create in nfsproc.c needs I_MUTEX_PARENT - I'll send a separate patch to fix that.
Thanks, NeilBrown
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |