Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] BLOCK: Make it possible to disable the block layer | Date | Thu, 24 Aug 2006 14:34:16 +0100 |
| |
David Woodhouse <dwmw2@infradead.org> wrote:
> > (*) The contents of a number of filesystem- and blockdev-specific header > > files are now contingent on their own configuration options. This > > includes: Ext3/JBD, RAID, MSDOS and ReiserFS. > > Why? Those header files shouldn't be included from anywhere _but_ the > code in question,
Go and look at fs/compat_ioctl.c.
> and in fact should probably be just moved into fs/foo instead of living in > include/linux/foo_fs.h.
Definitely. Patches please:-)
> And please, _never_ make anything dependent on CONFIG_foo_MODULE.
Ah, but... The core kernel makes use of the certain header files, even when their actual intended target is compiled as a module. If I just use "CONFIG_foo" only, then the module won't compile as a module.
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |