Messages in this thread |  | | | Subject | Re: [RFC][PATCH 4/4] Rename lock_cpu_hotplug/unlock_cpu_hotplug | | From | Arjan van de Ven <> | | Date | Thu, 24 Aug 2006 13:00:00 +0200 |
| |
On Thu, 2006-08-24 at 16:04 +0530, Gautham R Shenoy wrote: > > > This patch renames lock_cpu_hotplug to cpu_hotplug_disable and > unlock_cpu_hotplug to cpu_hotplug_enable throughout the kernel.
Hi,
to be honest I dislike the new names too. You turned it into a refcount, which is good, but the normal linux name for such refcount functions is _get and _put..... and in addition the refcount technically isn't hotplug specific, all you want is to keep the kernel data for the processor as being "used", so cpu_get() and cpu_put() would sound reasonable names to me, or cpu_data_get() cpu_data_put().
Greetings, Arjan van de Ven
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |