lkml.org 
[lkml]   [2006]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] Manage jbd allocations from its own slabs
On Wed, 23 Aug 2006 16:08:15 -0700
Badari Pulavarty <pbadari@us.ibm.com> wrote:

> Hi,
>
> Here is the fix to "bh: Ensure bh fits within a page" problem
> caused by JBD.
>
> BTW, I realized that this problem can happen only with 1k, 2k
> filesystems - as 4k, 8k allocations disable slab debug
> automatically. But for completeness, I created slabs for those
> also.
>
> What do you think ? I ran basic tests and things are fine.
>

Thanks for working on this.

> ...
>
> /*
> + * jbd slab management: create 1k, 2k, 4k, 8k slabs and allocate
> + * frozen and commit buffers from these slabs.
> + *
> + * Reason for doing this is to avoid, SLAB_DEBUG - since it could
> + * cause bh to cross page boundary.
> + */
> +
> +static kmem_cache_t *jbd_slab[4];
> +static const char *jbd_slab_names[4] = {
> + "jbd_1k",
> + "jbd_2k",
> + "jbd_4k",
> + "jbd_8k",
> +};
> +
> +static void journal_destroy_jbd_slabs(void)
> +{
> + int i;
> +
> + for (i=0; i<4; i++) {
> + if (jbd_slab[i])
> + kmem_cache_destroy(jbd_slab[i]);
> + jbd_slab[i] = NULL;
> + }
> +}
> +
> +static int journal_init_jbd_slabs(void)
> +{
> + int i = 0;
> + int retval = 0;
> +
> + for (i=0; i<4; i++) {
> + unsigned long slab_size = 1024 << i;
> + jbd_slab[i] = kmem_cache_create(jbd_slab_names[i],
> + slab_size, slab_size,
> + 0, NULL, NULL);

OK, passing align=slab_size fixes the bug.

> + if (jbd_slab[i] == 0) {
> + journal_destroy_jbd_slabs();
> + retval = -ENOMEM;
> + printk(KERN_EMERG "JBD: no memory for jbd_slab cache\n");
> + goto out;
> + }
> + }
> +out:
> + return retval;
> +}

Do we have to create all four slabs up-front? Perhaps we can defer that
until mount-time, after we have determined the filesystem's block size.

That way, most people's machines will only ever create a single slab cache:
jbd_4k.

> +static int jbd_find_slab_index(size_t size)
> +{
> + int idx = 0;
> +
> + switch (size) {
> + case 1024: idx = 0;
> + break;
> + case 2048: idx = 1;
> + break;
> + case 4096: idx = 2;
> + break;
> + case 8192: idx = 3;
> + break;
> + default: printk("JBD unknown slab size %ld\n", size);
> + BUG();
> + }
> + return idx;
> +}

I'd suggest this function be changed to directly return a kmem_cache_t *.

> +void * jbd_slab_alloc(size_t size, gfp_t flags)
> +{
> + int idx;
> +
> + idx = jbd_find_slab_index(size);
> + return kmem_cache_alloc(jbd_slab[idx], flags | __GFP_NOFAIL);
> +}
> +
> +void jbd_slab_free(void *ptr, size_t size)
> +{
> + int idx;
> +
> + idx = jbd_find_slab_index(size);
> + kmem_cache_free(jbd_slab[idx], ptr);
> +}

Then these become simpler.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-24 01:37    [W:0.071 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site