lkml.org 
[lkml]   [2006]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 9/18] 2.6.17.9 perfmon2 patch for review: kernel-level interface support
    On Wed, 23 Aug 2006 16:29:59 +0100
    Christoph Hellwig <hch@infradead.org> wrote:

    > On Wed, Aug 23, 2006 at 01:06:00AM -0700, Stephane Eranian wrote:
    > > This patch contains the kernel-level API support.
    > >
    > >
    > > Some users have requested the ability to create a monitoring session
    > > with perfmon2 from iside the kernel using a kernel thread. Perfmon2
    > > leverages a lot of kernel mechanisms which are not easy to use for
    > > inside the kernel: e.g. file descriptor, signals, system calls.
    >
    > Again, please drop this. There are no planned intree kernel users
    > so far, and once we add them we can architect a proper API for them.
    > Getting rid of this should also help to collapse the tons of useless
    > abstractions layers in the current perfmon code.
    >

    Yes, I think we either need a stronger argument for including this code, or
    we drop it.

    It is especially worrisome that the exports which are added here are plain
    old EXPORT_SYMBOL().

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-24 01:07    [W:0.021 / U:1.628 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site