Messages in this thread |  | | | From | Andi Kleen <> | | Subject | Re: [PATCH 2/6] BC: beancounters core (API) | | Date | Wed, 23 Aug 2006 15:48:05 +0200 |
| |
On Wednesday 23 August 2006 15:27, Kirill Korotaev wrote: > Andi Kleen wrote: > > On Wednesday 23 August 2006 13:03, Kirill Korotaev wrote: > > > > > >>+#ifdef CONFIG_BEANCOUNTERS > >>+extern struct hlist_head bc_hash[]; > >>+extern spinlock_t bc_hash_lock; > > > > > > I wonder who pokes into that hash from other files? Looks a bit dangerous. > it was kernel/ub/proc.c with proc interface :) > however, we removed it from this patchset version, but forgot extern's... > > will remove
Best remove the EXPORT_SYMBOLs too and make it static.
> >>+void __put_beancounter(struct beancounter *bc); > >>+static inline void put_beancounter(struct beancounter *bc) > >>+{ > >>+ __put_beancounter(bc); > >>+} > > > > > > The wrapper seems pointless too. > yep, almost the same reason :) > > > The file could use a overview comment what the various counter > > types actually are. > you mean comment about what resource parameters we introduce?
I meant about what a barrier counter etc. is and what makes it different from other counters.
The individual resources can be probably described elswhere.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |