Messages in this thread | | | Subject | Re: [patch 1/5] fail-injection library | From | Andi Kleen <> | Date | 23 Aug 2006 14:09:31 +0200 |
| |
Akinobu Mita <mita@miraclelinux.com> writes: > + if (failure_probability(data) == 100 || > + INT_MAX / 100 * failure_probability(data) > get_random_int())
I don't think it's a good idea to use get_random_int here. It's a secure quite heavyweight random simulator that eats up precious entropy.
I would use something simple with an option for the user to specify the seed (default jiffies maybe) for reproducibility.
e.g. the perfmon patchkit that was just posted had a reasonable simple pseudo RND for lib/. Maybe you can reuse that.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |