lkml.org 
[lkml]   [2006]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/2] Fix i_state of inode is changed after the inode is freed [try #2]
    From
    Date
    Fix i_state of the inode is changed after the inode is freed.

    Signed-off-by: Masayuki Saito <m-saito@tnes.nec.co.jp>
    Signed-off-by: ASANO Masahiro <masano@tnes.nec.co.jp>
    ---

    --- linux-2.6.17.7/fs/xfs/xfs_inode.c.orig 2006-08-21 20:15:58.385211286 +0900
    +++ linux-2.6.17.7/fs/xfs/xfs_inode.c 2006-08-21 21:21:22.277033371 +0900
    @@ -2751,18 +2751,30 @@ xfs_iunpin(
    * call as the inode reclaim may be blocked waiting for
    * the inode to become unpinned.
    */
    + int need_iput = 0;
    + struct inode *inode;
    + spin_lock(&ip->i_flags_lock);
    if (!(ip->i_flags & (XFS_IRECLAIM|XFS_IRECLAIMABLE))) {
    vnode_t *vp = XFS_ITOV_NULL(ip);

    /* make sync come back and flush this inode */
    if (vp) {
    - struct inode *inode = vn_to_inode(vp);
    + inode = vn_to_inode(vp);

    - if (!(inode->i_state & I_NEW))
    - mark_inode_dirty_sync(inode);
    + if (!(inode->i_state &
    + (I_NEW|I_FREEING|I_CLEAR))) {
    + inode = igrab(inode);
    + if (inode) {
    + need_iput = 1;
    + mark_inode_dirty_sync(inode);
    + }
    + }
    }
    }
    + spin_unlock(&ip->i_flags_lock);
    wake_up(&ip->i_ipin_wait);
    + if (need_iput)
    + iput(inode);
    }
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-08-23 13:17    [W:3.339 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site