![]() | |||||||||||
Messages in this thread |
On 8/22/06, David Miller <davem@davemloft.net> wrote: > From: "Eric Brower" <ebrower@gmail.com> > Date: Tue, 22 Aug 2006 20:59:14 -0700 > > > The envctrl OOPS is definately my fault in the blind conversion of the > > driver to the OF interface-- of_find_propery() return values should be > > checked for NULL rather than relying upon a -1 value stored into lenp. > > We can discuss this separately, since you are using an out-of-kernel > > driver. > > Ok. > > BTW, it is better to use "of_get_property()" if you are actually > interested in the value since it will return a void pointer to the > property value instead of a "struct property". of_find_property() is > useful if you just want to check for existence or if you want to > modify the property value. > Thanks, Dave. This driver is interested in property existence and length-- some OBP versions don't create all expected envctrl properties, and due to lack of implementation documentation the property lengths are being checked as well; so of_find_property() seems appropriate in this case. Would you consider assigning -1 to lenp (if provided) in of_find_property() when no matching device is found? Thanks, E -- E - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||
| Last update: 2006-08-23 07:37 [from the cache] ©2003-2008 | |||||||||||