lkml.org 
[lkml]   [2006]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [take12 3/3] kevent: Timer notifications.
On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig (hch@infradead.org) wrote:
> > +static int __init kevent_init_timer(void)
> > +{
> > + struct kevent_callbacks tc = {
> > + .callback = &kevent_timer_callback,
> > + .enqueue = &kevent_timer_enqueue,
> > + .dequeue = &kevent_timer_dequeue};
>
> I think this should be static, and the normal style to write it would be:
>
> static struct kevent_callbacks tc = {
> .callback = kevent_timer_callback,
> .enqueue = kevent_timer_enqueue,
> .dequeue = kevent_timer_dequeue,
> };
>
> also please consider makring all the kevent_callbacks structs const
> to avoid false cacheline sharing and accidental modification, similar
> to what we did to various other operation vectors.

Actually I do not think it should be static, since it is only used for
initialization and it's members are copied into main structure.

--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-21 14:13    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site