lkml.org 
[lkml]   [2006]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6.19 PATCH 2/7] ehea: pHYP interface
    Alexey Dobriyan wrote:
    > On Fri, Aug 18, 2006 at 01:30:21PM +0200, Jan-Bernd Themann wrote:
    >> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_phyp.c
    >> +++ kernel/drivers/net/ehea/ehea_phyp.c
    >
    >> + hret = ehea_h_register_rpage(hcp_adapter_handle, pagesize, queue_type,
    >> + eq_handle, log_pageaddr, count);
    >> + return hret;
    >
    > Just
    > return ehea_h_register_rpage(...);
    >
    >> + hret = ehea_h_register_rpage(hcp_adapter_handle, pagesize, queue_type,
    >> + cq_handle, log_pageaddr, count);
    >> + return hret;
    >
    > Ditto.
    >
    >> + hret = ehea_h_register_rpage(hcp_adapter_handle, pagesize, queue_type,
    >> + qp_handle, log_pageaddr, count);
    >> + return hret;
    >> +}
    >
    > Ditto.

    Returncode handling was reworked throughout the whole driver. Those assignments
    were modified according to your suggestion.

    >> +static inline int hcp_epas_ctor(struct h_epas *epas, u64 paddr_kernel,
    >> + u64 paddr_user)
    >> +{
    >> + epas->kernel.fw_handle = (u64) ioremap(paddr_kernel, PAGE_SIZE);
    >> + epas->user.fw_handle = paddr_user;
    >> + return 0;
    >> +}
    >> +
    >> +static inline int hcp_epas_dtor(struct h_epas *epas)
    >> +{
    >> +
    >> + if (epas->kernel.fw_handle)
    >> + iounmap((void *)epas->kernel.fw_handle);
    >> + epas->user.fw_handle = epas->kernel.fw_handle = 0;
    >> + return 0;
    >> +}
    >
    > Always returns 0;

    Correct. They're returning void now.

    Thanks
    Thomas
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-21 12:25    [W:0.029 / U:65.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site