Messages in this thread | | | Subject | Re: [PATCH 2/6]: powerpc/cell spidernet low watermark patch. | From | Benjamin Herrenschmidt <> | Date | Sun, 20 Aug 2006 16:31:49 +1000 |
| |
> card->low_watermark->next->dmac_cmd_status |= SPIDER_NET_DESCR_TXDESFLG; > mb(); > card->low_watermark->dmac_cmd_status &= ~SPIDER_NET_DESCR_TXDESFLG; > card->low_watermark = card->low_watermark->next; > > when we queue another frame for TX.
I would have expected those to be racy vs. the hardware... what if the hardware is updating dmac_cmd_status just as your are trying to and the bit out of it ?
Ben
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |