lkml.org 
[lkml]   [2006]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling
    Andrew, Michal:

    * Michal Piotrowski <michal.k.k.piotrowski@gmail.com> [2006-08-20 22:44:30 +0200]:
    > This patch fixes 56 sparse "ignoring return value of 'device_create_file'" warnings. It also adds error handling.
    >
    > w83627hf.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++-----------
    > 1 file changed, 80 insertions(+), 16 deletions(-)

    Thanks for doing this... but Andrew please don't apply it. The sensors project
    people are working on these even now, and we already have a patch for the
    w83627hf driver...

    http://lists.lm-sensors.org/pipermail/lm-sensors/2006-August/017204.html

    Jean Delvare (hwmon maintainer) should be sending these up the chain soon.

    Michal: if you're interested in fixing any of the rest of them, please take
    a look at the patch above to see the mechanism we intend to use. It actually
    makes the drivers *smaller* than they were.

    Regards,

    --
    Mark M. Hoffman
    mhoffman@lightlink.com

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-21 04:35    [W:0.022 / U:0.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site