lkml.org 
[lkml]   [2006]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch] Signedness issue in drivers/scsi/ipr.c
    Eric Sesterhenn wrote:
    > hi,
    >
    > gcc 4.1 with some extra warnings show the following:
    >
    > drivers/scsi/ipr.c:6361: warning: comparison of unsigned expression < 0 is always false
    > drivers/scsi/ipr.c:6385: warning: comparison of unsigned expression < 0 is always false
    > drivers/scsi/ipr.c:6415: warning: comparison of unsigned expression < 0 is always false

    Acked-by: Brian King <brking@us.ibm.com>

    >
    > The problem is that rc is of the type u32, which can never be smaller than zero,
    > therefore all three error handling checks get useless. This patch changes it to
    > a normal int, because all usages / all functions it get used with expect an int.
    >
    > Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
    >
    > --- linux-2.6.18-rc4/drivers/scsi/ipr.c.orig 2006-08-19 21:10:18.000000000 +0200
    > +++ linux-2.6.18-rc4/drivers/scsi/ipr.c 2006-08-19 21:10:25.000000000 +0200
    > @@ -6324,7 +6324,7 @@ static int __devinit ipr_probe_ioa(struc
    > struct Scsi_Host *host;
    > unsigned long ipr_regs_pci;
    > void __iomem *ipr_regs;
    > - u32 rc = PCIBIOS_SUCCESSFUL;
    > + int rc = PCIBIOS_SUCCESSFUL;
    > volatile u32 mask, uproc;
    >
    > ENTER;
    >
    >

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-20 21:01    [W:0.023 / U:0.272 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site