lkml.org 
[lkml]   [2006]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [2.6.19 PATCH 4/7] ehea: ethtool interface
    From
    Date
    On Fri, 2006-08-18 at 17:41 +0200, Thomas Klein wrote:
    > Hi Alexey,
    >
    > first of all thanks a lot for the extensive review.
    >
    >
    > Alexey Dobriyan wrote:
    > >> + u64 hret = H_HARDWARE;
    > >
    > > Useless assignment here and everywhere.
    > >
    >
    > Initializing returncodes to errorstate is a cheap way to prevent
    > accidentally returning (uninitalized) success returncodes which
    > can lead to catastrophic misbehaviour.

    If you try to return an uninitialized value the compiler will warn you,
    you'll then look at the code and realise you missed a case, you might
    save yourself a bug. By unconditionally initialising you are lying to
    the compiler, and it can no longer help you.

    cheers

    --
    Michael Ellerman
    IBM OzLabs

    wwweb: http://michael.ellerman.id.au
    phone: +61 2 6212 1183 (tie line 70 21183)

    We do not inherit the earth from our ancestors,
    we borrow it from our children. - S.M.A.R.T Person
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2006-08-19 08:21    [W:0.031 / U:3.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site