lkml.org 
[lkml]   [2006]   [Aug]   [15]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 15 Aug 2006 19:13:19 -0700
FromAndrew Morton <>
SubjectRe: [PATCH] [2/3] Create call_usermodehelper_pipe()
On Tue, 15 Aug 2006 14:22:25 -0700
Andrew Morton <akpm@osdl.org> wrote:

> On Mon, 14 Aug 2006 13:27:31 +0200 (CEST)
> Andi Kleen <ak@suse.de> wrote:
> 
> > +	/* Install input pipe when needed */
> > +	if (sub_info->stdin) {
> > +		struct files_struct *f = current->files;
> > +		struct fdtable *fdt;
> > +		/* no races because files should be private here */
> > +		sys_close(0);
> > +		fd_install(0, sub_info->stdin);
> > +		spin_lock(&f->file_lock);
> > +		fdt = files_fdtable(f);
> > +		FD_SET(0, fdt->open_fds);
> > +		FD_CLR(0, fdt->close_on_exec);
> > +		spin_unlock(&f->file_lock);
> > +	}
> 
> This is all going to be run by kernel threads, and all kernel threads share
> current->files=&init_files.

hm, that's wrong, isn't it - we're not using CLONE_FILES...

So what we have is a copy of init_files.  So the sys_close(0) shouldn't be needed?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-16 04:15    [from the cache]
©2003-2008