Messages in this thread | | | Subject | Re: [PATCH 2/7] proc: Modify proc_pident_lookup to be completely table driven. | From | Dave Hansen <> | Date | Tue, 15 Aug 2006 11:31:51 -0700 |
| |
On Tue, 2006-08-15 at 12:05 -0600, Eric W. Biederman wrote: > Currently proc_pident_lookup gets the names and types from a table > and then has a huge switch statement to get the inode and file > operations it needs. That is silly and is becoming increasingly hard > to maintain so I just put all of the information in the table.
Looks pretty reasonable.
> +#define INF(TYPE, NAME, MODE, OTYPE) \ > + NOD(TYPE, NAME, (S_IFREG|(MODE)), \ > + NULL, &proc_info_file_operations, \ > + { .proc_read = &proc_##OTYPE } ) ... > + INF(PROC_TID_OOM_SCORE, "oom_score", S_IRUGO, oom_score), > + REG(PROC_TID_OOM_ADJUST, "oom_adj", S_IRUGO|S_IWUSR, oom_adjust),
Could we give these some slightly more intuitive names? INF is a bit terse ;)
Since these #defines and function are also all in base.c, and not referenced elsewhere, might it be reasonable to take some of the PROC_ headers off of them? I know I've been frustrated more than once by popping things like "oom_score" in to cscope and finding no definitions.
-- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |