Messages in this thread Patch in this message |  | | | Date | Tue, 15 Aug 2006 02:40:46 +0200 | | From | Adrian Bunk <> | | Subject | [2.6 patch] orinoco.h: "extern inline" -> "static __always_inline" |
| |
"extern inline" generates a warning with -Wmissing-prototypes and I'm currently working on getting the kernel cleaned up for adding this to the CFLAGS since it will help us to avoid a nasty class of runtime errors.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- drivers/net/wireless/orinoco.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- linux-2.6.18-rc4-mm1/drivers/net/wireless/orinoco.h.old 2006-08-13 23:14:05.000000000 +0200 +++ linux-2.6.18-rc4-mm1/drivers/net/wireless/orinoco.h 2006-08-13 23:14:39.000000000 +0200 @@ -138,8 +138,8 @@ * SPARC, due to its weird semantics for save/restore flags. extern * inline should prevent the kernel from linking or module from * loading if they are not inlined. */ -extern inline int orinoco_lock(struct orinoco_private *priv, - unsigned long *flags) +static __always_inline int orinoco_lock(struct orinoco_private *priv, + unsigned long *flags) { spin_lock_irqsave(&priv->lock, *flags); if (priv->hw_unavailable) { @@ -151,8 +151,8 @@ return 0; } -extern inline void orinoco_unlock(struct orinoco_private *priv, - unsigned long *flags) +static __always_inline void orinoco_unlock(struct orinoco_private *priv, + unsigned long *flags) { spin_unlock_irqrestore(&priv->lock, *flags); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |