Messages in this thread | | | Date | Mon, 14 Aug 2006 15:14:26 +0200 | From | Jan-Bernd Themann <> | Subject | Re: [PATCH 2/6] ehea: pHYP interface |
| |
Hi
Anton Blanchard wrote: > Hi, > >> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_phyp.c 1969-12-31 16:00:00.000000000 -0800 > >> +u64 ehea_h_alloc_resource_eq(const u64 hcp_adapter_handle, > ... >> +u64 hipz_h_reregister_pmr(const u64 adapter_handle, > ... >> +static inline int hcp_galpas_ctor(struct h_galpas *galpas, > > Be nice to have some consistent names, hipz_ and hcp_ is kind of > cryptic.
We choose some more meaningful names and added comments to explain those.
> >> +#define H_QP_CR_STATE_RESET 0x0000010000000000 /* Reset */ > > Probably want ULL on here and the other 64bit constants. >
ULL added
> Anton
Jan-Bernd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |