Messages in this thread | | | Date | Sun, 13 Aug 2006 20:19:34 -0700 (PDT) | Subject | Re: [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming | From | David Miller <> |
| |
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Sun, 13 Aug 2006 22:59:11 +1000
> On Sat, Aug 12, 2006 at 09:19:19PM +0000, Nix wrote: > > > > The kernel log showed a heap of BUGs from somewhere inside the skb > > management layer, somewhere in UDP fragment processing while > > handling NFS requests. It starts like this: > > > > Aug 12 21:31:08 hades warning: kernel: BUG: warning at include/linux/skbuff.h:975/__skb_trim() > > Aug 12 21:31:08 hades warning: kernel: <c030ed39> ip_append_data+0x5b3/0x951 <c030fc18> ip_generic_getfrag+0x0/0x96 > > Oops, I missed this code path when I disallowed skb_trim from operating > on a paged skb. This patch should fix the problem. > > Greg, we need this for 2.6.17 stable as well if Dave is OK with it. > > [INET]: Use pskb_trim_unique when trimming paged unique skbs ... > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Looks good, Greg please push to -stable. I'll push this into 2.6.18 under seperate cover.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |