lkml.org 
[lkml]   [2006]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] Re: 2.6.18-rc3-mm2 - OOM storm

    Le 12.08.2006 17:07, Mike Galbraith a écrit :
    > On Thu, 2006-08-10 at 02:19 -0700, Andrew Morton wrote:
    >
    >> It would be interesting to try disabling CONFIG_ADAPTIVE_READAHEAD -
    >> perhaps that got broken.
    >
    > A typo was pinning pagecache. Fixes leak encountered with rpm -qaV.

    Problem fixed here too. Thanks

    > Signed-off-by: Mike Galbraith <efault@gmx.de>
    >
    > --- linux-2.6.18-rc3-mm2/mm/filemap.c.org 2006-08-12 14:04:14.000000000 +0000
    > +++ linux-2.6.18-rc3-mm2/mm/filemap.c 2006-08-12 14:07:53.000000000 +0000
    > @@ -1498,7 +1498,7 @@ retry_find:
    > page_cache_readahead_adaptive(mapping, ra,
    > file, NULL, NULL,
    > pgoff, pgoff, pgoff + 1);
    > - page = find_lock_page(mapping, pgoff);
    > + page = find_get_page(mapping, pgoff);
    > } else if (PageReadahead(page)) {
    > page_cache_readahead_adaptive(mapping, ra,
    > file, NULL, page,
    >
    >

    --
    laurent
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-12 23:27    [W:4.123 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site