lkml.org 
[lkml]   [2006]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH try #2] fuse: fix error case in fuse_readpages
Date
Andrew Morton <akpm@osdl.org> wrote:

> > Don't let fuse_readpages leave the @pages list not empty when exiting
> > on error.
> >
>
> Oh dear. read_cache_pages_release_page() is not a readahead thing. It is
> a dhowells fscache thing.

The pages passed to read_cache_pages() may already be marked with metadata
information (such as to-be-cached marks from NFS or AFS calling FS-Cache), so
we can't just ditch the pages on an error, we have to clean them up properly.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-11 10:15    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site