lkml.org 
[lkml]   [2006]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 5/6] Convert to use mutexes instead of semaphores
    On 8/11/06, Dmitry Torokhov <dtor@insightbb.com> wrote:
    > Backlight: convert to use mutexes instead of semaphores
    >

    Apparently I missed that several drivers also use bd->sem so they need
    to be converted too... But what is it with the drivers:

    static void aty128_bl_set_power(struct fb_info *info, int power)
    {
    mutex_lock(&info->bl_mutex);
    up(&info->bl_dev->sem);
    info->bl_dev->props->power = power;
    __aty128_bl_update_status(info->bl_dev);
    down(&info->bl_dev->sem);
    mutex_unlock(&info->bl_mutex);
    }

    Why we are doing up() before down()??? And it is in almost every
    driver that uses backlight... Do I need more coffee? [CC-ing bunch of
    people trying to get an answer...]

    --
    Dmitry
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-11 15:01    [W:0.024 / U:121.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site