Messages in this thread | | | Subject | Re: + r-o-bind-mount-clean-up-ocfs2-nlink-handling.patch added to -mm tree | From | Daniel Walker <> | Date | Thu, 10 Aug 2006 09:07:26 -0700 |
| |
On Thu, 2006-08-10 at 09:02 -0700, Dave Hansen wrote:
> > There's one too many drop_nlink()'s in this block, unless I'm not > > reading this right. > > It needs to be double-dropped for any directory inodes. Some of the > older code just did i_nlink-=2, and I chose to just call drop_nlink() > twice instead of making another helper to do arbitrary arithmetic on > i_nlink. > > I believe this made up for the > > if (S_ISDIR(inode->i_mode)) > inode->i_nlink = 0; > > in the old code.
Ok, I had a feeling it was something like that .. A comment around there might be helpful though, so people don't query you on in the future.
Daniel
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |