Messages in this thread |  | | | Date | Tue, 1 Aug 2006 08:12:25 +0400 | | From | Alexey Dobriyan <> | | Subject | Re: [PATCH] task_struct: remove writeonly counters |
| |
On Mon, Jul 31, 2006 at 09:01:07PM -0700, Andrew Morton wrote: > On Tue, 1 Aug 2006 06:29:51 +0400 > Alexey Dobriyan <adobriyan@gmail.com> wrote: > > > ... > > > > +++ b/include/linux/sched.h > > @@ -962,8 +962,6 @@ #endif > > * to a stack based synchronous wait) if its doing sync IO. > > */ > > wait_queue_t *io_wait; > > -/* i/o counters(bytes read/written, #syscalls */ > > - u64 rchar, wchar, syscr, syscw; > > This is kinda funny. These fields were added a year and a half ago, with > the intention that the info be made available to userspace. But then > things got horridly stuck. It's only in the past couple of weeks that we've > gained appropriate reporting-to-userspace infrastructure to be able to use > these fields. > > And lo, on the very day when you propose removing these fields, Jay posts a > new patchset ("add CSA accounting to taskstats") which finally gets around to > using them.
[checks archives] *cough* That was a coincidence, I assure you.
> So.. we should keep these fields for now - we can perhaps remove them (in > less than 1.5 years) if for some reason the CSA patches crash and burn (I > don't think they will).
Perhaps, Jay can properly ifdef them with CONFIG_CSA_ACCT or something? And remove in-file changelogs 'cause there is git?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |