Messages in this thread | | | Date | Tue, 1 Aug 2006 14:14:10 -0700 | From | Chris Wright <> | Subject | Re: [PATCH 1 of 13] Add apply_to_page_range() which applies a function to a pte range |
| |
* Eric W. Biederman (ebiederm@xmission.com) wrote: > - You don't handle huge pages. For a generic function > that sounds like a problem. > - I believe there is a reason the kernel doesn't already have > a function like this. I seem to recall there being efficiency > and fast path arguments. > - Placing this code in mm/memory.c without a common consumer is > pure kernel bloat for everyone who doesn't use this function, > which is just about everyone.
We got the opposite feedback the first time we posted this function. Xen has some users, and I believe there's a couple in-tree functions we could convert easily w/out overhead issues. It's generic and this is just the infrastructure, I think we should leave it.
thanks, -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |