Messages in this thread | | | Date | Tue, 1 Aug 2006 22:12:57 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] ifdef blktrace debugging fields |
| |
On Tue, Aug 01 2006, Alexey Dobriyan wrote: > On Tue, Aug 01, 2006 at 09:44:36AM +0200, Jens Axboe wrote: > > Certainly. If Alexey adds the blkdev.h bit as well, we can go ahead with > > it. > > Done. Originally I looked at slab size of task_struct and still > recovering.
;-)
> [PATCH] ifdef blktrace debugging fields > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> > --- > > block/ll_rw_blk.c | 4 ++-- > include/linux/blkdev.h | 4 ++-- > include/linux/sched.h | 3 ++- > kernel/fork.c | 2 ++ > 4 files changed, 8 insertions(+), 5 deletions(-) > > --- a/block/ll_rw_blk.c > +++ b/block/ll_rw_blk.c > @@ -1779,10 +1779,10 @@ static void blk_release_queue(struct kob > > if (q->queue_tags) > __blk_queue_free_tags(q); > - > +#ifdef CONFIG_BLK_DEV_IO_TRACE > if (q->blk_trace) > blk_trace_shutdown(q); > - > +#endif > kmem_cache_free(requestq_cachep, q); > }
That can be made ifdef less, if you unconditionally call blk_trace_shutdown() and just make that one do:
if (q->blk_trace) { ... }
since that'll then do the right always. Please make that change, then I'm fine with the patch.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |