lkml.org 
[lkml]   [2006]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/33] i386: CONFIG_PHYSICAL_START cleanup
    On Tue, Aug 01, 2006 at 05:03:19AM -0600, Eric W. Biederman wrote:
    > Defining __PHYSICAL_START and __KERNEL_START in asm-i386/page.h works but
    > it triggers a full kernel rebuild for the silliest of reasons. This
    > modifies the users to directly use CONFIG_PHYSICAL_START and linux/config.h
    > which prevents the full rebuild problem, which makes the code much
    > more maintainer and hopefully user friendly.
    >
    > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
    > ---
    > arch/i386/boot/compressed/head.S | 8 ++++----
    > arch/i386/boot/compressed/misc.c | 8 ++++----
    > arch/i386/kernel/vmlinux.lds.S | 3 ++-
    > include/asm-i386/page.h | 3 ---
    > 4 files changed, 10 insertions(+), 12 deletions(-)
    >
    > diff --git a/arch/i386/boot/compressed/head.S b/arch/i386/boot/compressed/head.S
    > index b5893e4..8f28ecd 100644
    > --- a/arch/i386/boot/compressed/head.S
    > +++ b/arch/i386/boot/compressed/head.S
    > @@ -23,9 +23,9 @@
    > */
    > .text
    >
    > +#include <linux/config.h>

    You already have full access to all CONFIG_* symbols - kbuild includes
    it on the commandline. So please kill this include.

    Sam
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-01 21:11    [W:0.024 / U:0.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site