Messages in this thread Patch in this message | | | Subject | RE: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS | Date | Fri, 7 Jul 2006 10:10:39 -0700 | From | "Luck, Tony" <> |
| |
> This patch broke (-rc1): > > sparc allnoconfig build > ia64 allnoconfig build > ppc64 allnoconfig build
ia64 allnoconfig is (and has been for a while) broken for other reasons.
Almost all of the real configurations still build. The only error that adding this turned up was building a generic uniprocessor config.
smp_call_function_single() is used without a prototype by arch/ia64/sn/kernel/sn2/sn_hwperf.c:sn_hwperf_op_cpu()
This isn't a real error because this function actually does return an "int", so the complier default is correct (plus the caller doesn't look at the return value, plus on a UP we'd never be able to get to this call-site because it is in the "else" !!!).
But I'll fix it anyway.
diff --git a/include/asm-ia64/smp.h b/include/asm-ia64/smp.h index 719ff30..949e3a2 100644 --- a/include/asm-ia64/smp.h +++ b/include/asm-ia64/smp.h @@ -133,6 +133,7 @@ #else #define cpu_logical_id(i) 0 #define cpu_physical_id(i) ia64_get_lid() +#define smp_call_function_single(cpuid, func, info, retry, wait) 0 #endif /* CONFIG_SMP */ #endif /* _ASM_IA64_SMP_H */ -Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |