lkml.org 
[lkml]   [2006]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: LibPATA code issues / 2.6.15.4


    On Fri, 7 Jul 2006, Mark Lord wrote:

    > Justin Piszcz wrote:
    >>
    >> had to change
    >>
    >> KERN_WARN -> KERN_WARNING
    >>
    >> then more errors
    >
    > Eh? After fixing the KERN_WARN -> KERN_WARNING part,
    > the patch compiles / links cleanly here on 2.6.17.
    > (fixed copy below). Still untested, though.
    >
    >> do you know who wrote the original patch?
    >
    > I did.
    >
    > Cheers
    >
    > --- linux/drivers/scsi/libata-scsi.c.orig 2006-06-19 10:37:03.000000000 -0400
    > +++ linux/drivers/scsi/libata-scsi.c 2006-07-07 09:06:57.000000000 -0400
    > @@ -542,6 +542,7 @@
    > struct ata_taskfile *tf = &qc->tf;
    > unsigned char *sb = cmd->sense_buffer;
    > unsigned char *desc = sb + 8;
    > + unsigned char ata_op = tf->command;
    >
    > memset(sb, 0, SCSI_SENSE_BUFFERSIZE);
    >
    > @@ -558,6 +559,7 @@
    > * onto sense key, asc & ascq.
    > */
    > if (tf->command & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
    > + printk(KERN_WARNING "ata_gen_ata_desc_sense: failed ata_op=0x%02x\n", ata_op);
    > ata_to_sense_error(qc->ap->id, tf->command, tf->feature,
    > &sb[1], &sb[2], &sb[3]);
    > sb[1] &= 0x0f;
    >

    Mark!! It did it again, here you go:

    ==> /p34/var/log/messages <==
    Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: status=0x53 {
    DriveReady SeekComplete Index Error }
    Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: error=0x04 {
    DriveStatusError }
    ==> /p34/var/log/kern.log <==
    Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: translated ATA stat/err
    0x53/04 to SCSI SK/ASC/ASCQ 0xb/00/00
    Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: status=0x53 {
    DriveReady SeekComplete Index Error }
    Jul 7 10:26:06 p34 kernel: [4296869.461000] ata4: error=0x04 {
    DriveStatusError }

    Does this help?

    Can we eliminate the cause of these errors now?

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-07 16:41    [W:4.364 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site