Messages in this thread | | | Subject | Re: [patch] spinlocks: remove 'volatile' | From | Arjan van de Ven <> | Date | Thu, 06 Jul 2006 11:34:31 +0200 |
| |
> > Shouldn't the __raw_read_can_lock and __raw_write_can_lock macros be changed too, just > to make sure the value gets read every single time if it's used in a loop? > Just like the __raw_spin_is_locked already has a (volatile signed char * cast)? > -
it shouldn't get a volatile case imo, just a barrier(). A barrier() at least has well defined semantics, unlike volatile...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |