lkml.org 
[lkml]   [2006]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] FRV: Fix FRV arch compile errors [try #3]
On Thu, 06 Jul 2006 19:25:03 +0100
David Howells <dhowells@redhat.com> wrote:

> Andrew Morton <akpm@osdl.org> wrote:
>
> > - The __init-style tags on declarations don't actually do anything and
> > the compiler doesn't check for consistency with the definition - it's
> > best to just omit it from the declaration.
>
> Well, you're wrong. They *do* do something. They stop the compiler using the
> register-relative addressing reserved for small data. If this isn't in there,
> then the linker will spit out a relocation error.

Sigh. So if we get this wrong (and we have, and we shall) then the error
gets silently accepted by the toolchain until someone comes along and tries
to link it on FVR.

Is there anything we can do about that? Mangling the names with some macro
isn't attractive. Teach sparse about it? Dunno.

Right now we're showing a grand total of two identifiers tagged with
__initdata in all of include/. Why isn't FRV blowing up all over the
place? Is there something about nr_kernel_pages which made us get unlucky?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-06 20:43    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site