lkml.org 
[lkml]   [2006]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.17-mm6

* Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:

> I wrote:
> > (Ieee1394 core's usage of the skb_* API is entirely unrelated to
> > networking; even if eth1394 was used.)
>
> PS:
> I wonder if it wouldn't be better to migrate ieee1394 core away from
> skb_*. I didn't look thoroughly at it yet but the benefit of using
> this API appears quite low to me.

yeah, it seems to be the wrong abstraction to use. It's also more
expensive than necessary: e.g. skb-heads have a qlen field that is
maintained in every list op - but the ieee1394 code does not make use of
the queue-length information. Using list.h plus a spinlock should do the
trick?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-05 13:21    [W:0.104 / U:3.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site