lkml.org 
[lkml]   [2006]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] uninline init_waitqueue_*() functions
On Wed, 5 Jul 2006 11:37:56 +0100
Christoph Hellwig <hch@infradead.org> wrote:

> On Wed, Jul 05, 2006 at 11:32:59AM +0200, Ingo Molnar wrote:
> >
> > * Andrew Morton <akpm@osdl.org> wrote:
> >
> > > shrinks fs/select.o by eight bytes. (More than I expected). So it
> > > does appear to be a space win, but a pretty slim one.
> >
> > there are 855 calls to these functions in the allyesconfig vmlinux i
> > did, and i measured a combined size reduction of 34791 bytes. That
> > averages to a 40 bytes win per call site. (on i386.)
>
> And more importantly it's a function that's called in slowpathes per
> definition. So saving text sounds like a good idea, how minimal it
> may be.
>

Well yes - as I said, it's a net win. But 31 bytes per callsite seems
weird and makes one wonder what's going on.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-05 12:47    [W:0.301 / U:0.008 seconds]
©2003-2014 Jasper Spaans. Advertise on this site