lkml.org 
[lkml]   [2006]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [CPUFREQ] Fix implicit declarations in ondemand.
On Wed, Jul 05, 2006 at 10:43:05AM +0100, David Woodhouse wrote:
> On Wed, 2006-07-05 at 02:36 -0700, Andrew Morton wrote:
> > On Wed, 5 Jul 2006 05:22:54 -0400 Dave Jones <davej@redhat.com> wrote:
> >
> > > drivers/cpufreq/cpufreq_ondemand.c: In function ‘dbs_check_cpu’:
> > > drivers/cpufreq/cpufreq_ondemand.c:238: error: implicit declaration
> > of function ‘jiffies64_to_cputime64’
> > > drivers/cpufreq/cpufreq_ondemand.c:239: error: implicit declaration
> > of function ‘cputime64_sub’
>
> > > +#include <asm/cputime.h>
>
> > But kernel_stat.h already includes cputime.h, as does sched.h, and
> > pretty much everything pulls in sched.h.
> >
> > It's not bad to avoid a dependency upon nested includes, but I do
> > wonder how this error came about??
>
> asm-powerpc/cputime.h doesn't declare jiffies64_to_cputime64() or
> cputime64_sub()

The curious part is why it isn't picking up the definition from asm-generic
like x86-64 & friends do.

Dave

--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-05 11:49    [W:0.060 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site