Messages in this thread | | | Date | Wed, 5 Jul 2006 02:36:41 -0700 | From | Andrew Morton <> | Subject | Re: [CPUFREQ] Fix implicit declarations in ondemand. |
| |
On Wed, 5 Jul 2006 05:22:54 -0400 Dave Jones <davej@redhat.com> wrote:
> drivers/cpufreq/cpufreq_ondemand.c: In function ‘dbs_check_cpu’: > drivers/cpufreq/cpufreq_ondemand.c:238: error: implicit declaration of function ‘jiffies64_to_cputime64’ > drivers/cpufreq/cpufreq_ondemand.c:239: error: implicit declaration of function ‘cputime64_sub’ > > Signed-off-by: Dave Jones <davej@redhat.com> > > --- linux-2.6/drivers/cpufreq/cpufreq_ondemand.c~ 2006-07-05 05:19:26.000000000 -0400 > +++ linux-2.6/drivers/cpufreq/cpufreq_ondemand.c 2006-07-05 05:20:01.000000000 -0400 > @@ -18,6 +18,7 @@ > #include <linux/jiffies.h> > #include <linux/kernel_stat.h> > #include <linux/mutex.h> > +#include <asm/cputime.h> >
But kernel_stat.h already includes cputime.h, as does sched.h, and pretty much everything pulls in sched.h.
It's not bad to avoid a dependency upon nested includes, but I do wonder how this error came about?? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |