Messages in this thread | | | Subject | Re: [PATCH] ixgb: add PCI Error recovery callbacks | From | "Zhang, Yanmin" <> | Date | Thu, 06 Jul 2006 09:21:39 +0800 |
| |
On Thu, 2006-07-06 at 03:44, Linas Vepstas wrote: > On Wed, Jul 05, 2006 at 08:49:27AM -0700, Auke Kok wrote: > > Zhang, Yanmin wrote: > > >On Fri, 2006-06-30 at 00:26, Linas Vepstas wrote: > > >>Adds PCI Error recovery callbacks to the Intel 10-gigabit ethernet > > >>ixgb device driver. Lightly tested, works. > > > > > >Both pci_disable_device and ixgb_down would access the device. It doesn't > > >follow Documentation/pci-error-recovery.txt that error_detected shouldn't > > >do > > >any access to the device. > > > > Moreover, it was Linas who wrote this documentation in the first place :) > > On the pSeries, its harmless to try to do i/o; the i/o will e blocked. In the future, we might move the pci error recovery codes to generic to support other platforms which might not block I/O. So it's better to follow Documentation/pci-error-recovery.txt when adding error recovery codes into driver. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |