Messages in this thread | | | From | Andreas Schwab <> | Subject | Re: NULL terminate over-long /proc/kallsyms symbols | Date | Wed, 05 Jul 2006 19:13:00 +0200 |
| |
Andreas Gruenbacher <agruen@suse.de> writes:
> Index: linux-2.6.17/kernel/module.c > =================================================================== > --- linux-2.6.17.orig/kernel/module.c > +++ linux-2.6.17/kernel/module.c > @@ -1935,7 +1935,7 @@ struct module *module_get_kallsym(unsign > if (symnum < mod->num_symtab) { > *value = mod->symtab[symnum].st_value; > *type = mod->symtab[symnum].st_info; > - strncpy(namebuf, > + strlcpy(namebuf, > mod->strtab + mod->symtab[symnum].st_name, > 127);
Just a minor point: you probably also want to change 127 to 128. Unfortunately sizeof does not work here, despite the declaration.
Andreas.
-- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |